Check for drop to prevent race conditions #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `inHandler` uses `setTimeout()` function to schedule `this.open()` call. If client calls `drop.destroy()` before timeout is triggered, the instance of `this.drop` will be set to `null` which results in unhandled error in `open()` This change fixes the unhandled error.
|
Thanks for doing this. I was about to open a similar pull request when I noticed this one. Based on CONTRIBUTING.md you'll need to run Also, I believe it's possible to run into a similar problem in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inHandlerusessetTimeout()function to schedulethis.open()call. If client callsdrop.destroy()before timeout is triggered, the instance ofthis.dropwill be set tonullwhich results in unhandled error inopen()This change fixes the unhandled error.