Surface httpUseLocalhost in the hs doctor check #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
|
The screenshot is slightly outdated. I updated the copy to: |
kemmerle
reviewed
Mar 11, 2025
lib/doctor/DiagnosticInfoBuilder.ts
Outdated
| @@ -36,6 +39,7 @@ export interface DiagnosticInfo extends FilesInfo { | |||
| path?: string; | |||
| versions: { [hubspotCli]: string; node: string; npm: string | null }; | |||
| config: string | null; | |||
| configSettings: Record<string, unknown>; | |||
There was a problem hiding this comment.
I think we're staying away from the Record pattern in favor of a plain object.
There was a problem hiding this comment.
Ah good catch. I fixed this in one place and forgot to do it here too
joe-yeager
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This sets up the
hs doctorcommand to be able to surface warnings when certain CLI settings are enabled. For now it's just surfacing a warning whenhttpUseLocalhostis true.Screenshots
TODO
Who to Notify