Fix Open Image Relative Path failing - New Try #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiderguy-F
changed the title
keianhzo
requested changes
Mar 14, 2024
| def draw(self, context): | ||
| layout = self.layout | ||
|
|
||
| def draw(self, context): #this def is obsolete, bc. target_property is hidden by default now and relative_path is displayed by default anyways |
There was a problem hiding this comment.
Is this is not required anymore in any of the supported Blender versions, I think we can safely remove it.
| def execute(self, context): | ||
| dirname = os.path.dirname(self.filepath) | ||
|
|
||
| #dirname = os.path.dirname(self.filepath) #dirname fails if path selected in the Blender File View is relative (starts with //) on Windows |
There was a problem hiding this comment.
This comment can be removed
There was a problem hiding this comment.
Done
check_style finds a few issues in other files as well, want me to fix that?
|
Thanks perfect, thanks! |
keianhzo
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cleaned up the chaos by creating a new branch. The behaviour should match the previous behaviour now, let's call it "intuitive".
class OpenImage(Operator)
fails when using the default 'relative_path' property (True) on Windows. Python os.path.join on Windows does not recognize '//' to be the beginning of a directory and treats it like a filename.
We fixed that error and made the file browser start where the previous image was located. We also modified the dedfault location of the File Viewer to either:
a) Start where a file was selected the last time the File View was used or:
b) if an image had been previously assigned to the target_property, the File View will start with that image selected.
This is Blender's default behaviour
It probably failed when selecting an image for a reflection probe as well and should be working everywhere now.