Fog Settings Only Display Relevant Parameters #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
requested changes
Mar 13, 2024
| @@ -29,7 +39,7 @@ class Fog(HubsComponent): | |||
| min=0, | |||
| max=1) | |||
|
|
|||
| # TODO Make these properties to be displayed dynamically based on the fog type | |||
| # TODO Make these properties to be displayed dynamically based on the fog type, BlenderDiplom: Done | |||
There was a problem hiding this comment.
Probably better to remove this as it's not a TODO anymore and the commit and the commit author already give you the information that you are adding.
| def draw(self, context, layout, panel): | ||
| '''Draw method to be called by the panel. The base class method will print all the component properties''' | ||
| layout.prop(data=self, property="type") | ||
| print("Type:", self.type) |
|
There are some formatting errors in the code, please run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a TODO in fog.py and resolved it:
The Fog component only shows Near and Far when Linear fog is selected and only Density when Exponential fog is selected