Fix the default particle emitter source example URL and add a warning #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default particle emitter source URL is an example URL that was supposed to resolve to the default particle if "example.org" was replaced with the domain of your instance; however the assets subdomain was erroneously omitted and it wasn't obvious that the default wouldn't work and what to change to make it work. This commit adds the missing subdomain and a warning that the default URL won't resolve unmodified with an explanation on what to change to correctly point it to the default white square particle on your instance.
Exairnous
force-pushed
the
fix-default-particle-image
branch
from
4755e61
to
b78a4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default particle emitter source URL is an example URL that was supposed to resolve to the default particle if "example.org" was replaced with the domain of your instance; however the assets subdomain was erroneously omitted and it wasn't obvious that the default wouldn't work and what to change to make it work.
This commit adds the missing subdomain and a warning that the default URL won't resolve unmodified with an explanation on what to change to correctly point it to the default white square particle on your instance.