Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KTX2/Draco loader to avatar-editor #6210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kira924age
Copy link

@kira924age kira924age commented Aug 14, 2023

Closes: #6209

I add KTX2/Draco Loader to avatar-editor.js.
Now we can upload KTX2/Draco glb file from avatar upload page.

Screenshot

Screencast.from.2023-08-14.12-39-52.webm

@Exairnous
Copy link
Contributor

It's great to see Draco support for avatars being added, but I thought KTX2 support was already present. I'm pretty sure I have created and uploaded an avatar with KTX2 texture compression to Hubs.

we donot need to call this method in this case
@kira924age
Copy link
Author

@Exairnous

Thank you for your comment. As you pointed out, I was able to upload the avatar using the KTX2 Texture even after removing the "setKTX2Loader" process. In this scenario, it seems that there is no need to call setKTX2Loader, so I have removed it. Perhaps in this case, only the uploading is being performed, and the texture loading might not be taking place.

@Exairnous
Copy link
Contributor

Perhaps, but I do see textures in the preview window with a KTX2 avatar, so not sure. Glad I could help anyway.

@keianhzo
Copy link
Contributor

KTX2 is used when rendering the model in the scene and in the avatar preview viewport (both via gltf-model-plus.js loadGLTF) but not during the uploadAvatar` step in the editor. The loader seems to be crashing only for the Draco extension and not for the Basis one, not sure why but I don't think we need to add the KTX2 loader as that extension is available when loading for rendering later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't upload draco or ktx2 glb as a custom avatar.
3 participants