WIP: Add lint restriction for Binder #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikhail57
changed the title
Hukumister
requested changes
Feb 17, 2021
| @@ -0,0 +1,27 @@ | |||
| plugins { | |||
| id("java-library") | |||
| id("kotlin") | |||
There was a problem hiding this comment.
Добавь сюда еще ktlint плагин
| import com.intellij.psi.PsiMethod | ||
| import org.jetbrains.uast.UCallExpression | ||
|
|
||
| class WrongGenimiUsageDetector : Detector(), SourceCodeScanner { |
There was a problem hiding this comment.
Вот тут есть подозрение, что используется старое API посмотри как сделано на нашем рабочем проекте (название не называю из-за NDA)
| import com.android.tools.lint.checks.infrastructure.LintDetectorTest | ||
|
|
||
| @Suppress("UnstableApiUsage") | ||
| class WrongGenimiUsageDetectorTest : LintDetectorTest() { |
There was a problem hiding this comment.
Тут у тестов тоже старое апи, желательно поднять версию, так как может тупить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add android lint rules to restrict usage of
Binder'sbindmethod outside ofonCreate