-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: DSS Events #102
Open
xbrianh
wants to merge
2
commits into
master
Choose a base branch
from
bhannafi-dss-event-journaling.md
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC: DSS Events #102
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
### DCP PR: | ||
|
||
***Leave this blank until the RFC is approved** then the **Author(s)** must create a link between the assigned RFC number and this pull request in the format:* | ||
|
||
`[dcp-community/rfc#](https://github.com/HumanCellAtlas/dcp-community/pull/<PR#>)` | ||
|
||
# RFC: Event Journaling and Replay for the Data Store (DSS) | ||
|
||
## Summary | ||
|
||
This RFC proposes DSS event journaling and replay API endpoints. | ||
|
||
## Author(s) | ||
|
||
* [Brian Hannafious](mailto:[email protected]) | ||
|
||
## Shepherd | ||
***Leave this blank.** This role is assigned by DCP PM to guide the **Author(s)** through the RFC process.* | ||
|
||
*Recommended format for Shepherds:* | ||
|
||
`[Name](mailto:[email protected])` | ||
|
||
## Motivation | ||
|
||
The DSS currently provides an event subscription service. Events are triggered when a bundle is created, tombstoned, or | ||
deleted, and may be filtered by applying [JMESPath](http://jmespath.org/) to the | ||
[metadata](https://github.com/HumanCellAtlas/metadata-schema) documents contained in the bundle. The DSS should also | ||
provide JMESPath filterable, and chronological, event replay. | ||
|
||
### User Stories | ||
|
||
* As a new DSS subscriber, I would like to replay the events prior to my subscription activation date. | ||
* As an existing DSS subscriber, I would like to recover from protracted downtime of my service. | ||
* As a DSS subscriber, I would like to test changes to my JMESPath subscriptions against specific bundles. | ||
|
||
## Detailed Design | ||
|
||
The DSS will provide two new API endpoints: | ||
1. GET /events, accepting `replica`, `from-date`, and `to-date`. This will return a paged listing of signed urls | ||
containing event journals. | ||
1. GET /event, accepting `replica`, `bundle-uuid`, and `bundle-version`. This will return the JSON | ||
xbrianh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
document produced during the bundle event. | ||
|
||
The event data for a single event will be the JSON metadata document currently produced for the DSS JMESPath event | ||
subscription service. | ||
|
||
Due to the (currently unbounded) size of the JSON metadata document, new events will be stored directly on object storage | ||
as single objects. An offline daemon will compile events into journals, as needed. | ||
xbrianh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Unresolved Questions | ||
xbrianh marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment to the one that I left in #101 - this Detailed Design appears to lack details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'll reference my comment to your comment in #101: #101 (comment)