Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint that the title name should be replaced #95

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Hint that the title name should be replaced #95

merged 3 commits into from
Jul 31, 2019

Conversation

mweiden
Copy link
Contributor

@mweiden mweiden commented Jul 30, 2019

@mweiden
Hint that the title name should be replaced
5a39bf5 
Many people are confused about usage here:
* #91 (comment)
* #90 (comment)
* ... have observed others
@mweiden mweiden requested a review from brianraymor July 30, 2019 22:43
brianraymor
brianraymor reviewed Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@brianraymor brianraymor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The charter template is similar. If comprehension is difficult then perhaps it should be:

Type the name of your RFC here

or the instructions could say:
"Replace RFC Name with the name of your RFC. Keep it short and descriptive.

brianraymor
brianraymor requested changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@brianraymor brianraymor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my earlier suggestions for better approaches ...

@mweiden mweiden merged commit 27522cd into master Jul 31, 2019
@mweiden mweiden deleted the mweiden-suggest-replacing-name branch July 31, 2019 22:24
diekhans pushed a commit to barkasn/dcp-community that referenced this pull request Aug 16, 2019
@mweiden @diekhans
Hint that the title name should be replaced (HumanCellAtlas#95)
5880874 
* Hint that the title name should be replaced

Many people are confused about usage here:
* HumanCellAtlas#91 (comment)
* HumanCellAtlas#90 (comment)
* ... have observed others

* Update rfc-template.md

* Update rfc-template.md
diekhans pushed a commit to diekhans/dcp-community that referenced this pull request Oct 31, 2019
@mweiden @diekhans
Hint that the title name should be replaced (HumanCellAtlas#95)
b419568 
* Hint that the title name should be replaced

Many people are confused about usage here:
* HumanCellAtlas#91 (comment)
* HumanCellAtlas#90 (comment)
* ... have observed others

* Update rfc-template.md

* Update rfc-template.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianraymor brianraymor brianraymor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweiden @brianraymor