-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gender_identity field and ontology. Fixes #1409. #1475
Conversation
Please ignore the "schema linting" failed action, it is complaining that the ontology branch has not been yet imported to the HCAO. The HCAO works by releases and this will be imported in our next release (~18th) HumanCellAtlas/ontology#113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
…nto esv-gender-identity-Issue1409
This was previously blocked by an ontology update that is now completed. This PR is updated with the GD network preferred ontology and merged current staging branch into this, so we are re-requesting reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release notes
For
type/biomaterial/donor_organism.json
schema:For
module/gender_identity_ontology.json
schema:Reviews requested
Rationale
This change was requested to support the metadata for the "Testis cell atlas" dataset, in which there are 2 testis samples from female-gendered individuals. It will also help wranglers in the future to be more inclusive for non-cis individuals.