Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added disease_profile module to donor_organism. Fixes#1578 #1579

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Added disease_profile module to donor_organism. Fixes#1578 #1579

merged 13 commits into from
Sep 30, 2024

Conversation

arschat
Copy link
Collaborator

@arschat arschat commented Sep 12, 2024

Release notes

For donor_organism schema, add a disease_profile module that includes the following fields:

  • copd_gold_stage
  • copd_mmrc_grade
  • copd_cat_score
  • copd_gold_abe_assessment
  • copd_phenotype
  • copd_emphysema_percentage

see #1578

Reviews requested

  • Need 5 Reviewers to approve because this is a major update

@arschat arschat closed this Sep 12, 2024
@arschat arschat reopened this Sep 12, 2024
ESapenaVentura
ESapenaVentura approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@ESapenaVentura ESapenaVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing versions.json (For new entities, you need to add it with version 0.0.0) and a small comment about what I think is a typo

Other than that, LGTM 👍

json_schema/module/biomaterial/disease_profile.json Outdated Show resolved Hide resolved
@arschat arschat merged commit 7614193 into staging Sep 30, 2024
2 of 5 checks passed
@arschat arschat deleted the ac-disease-profile-module-Issue1578 branch September 30, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idazucchi idazucchi idazucchi left review comments

@ncalvanese1 ncalvanese1 ncalvanese1 approved these changes

@ESapenaVentura ESapenaVentura ESapenaVentura approved these changes

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

@NoopDog NoopDog NoopDog approved these changes

@amnonkhen amnonkhen amnonkhen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arschat @amnonkhen @NoopDog @hannes-ucsc @ESapenaVentura @idazucchi @ncalvanese1