Extend atlas names #1584
Merged
Extend atlas names #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arschat
requested review from
amnonkhen,
NoopDog,
hannes-ucsc,
ESapenaVentura and
ncalvanese1
ncalvanese1
approved these changes
Oct 9, 2024
ESapenaVentura
approved these changes
Oct 9, 2024
json_schema/update_log.csv
Outdated
| @@ -1 +1,2 @@ | |||
| Schema,Change type,Change message,Version,Date | |||
| module/project/hca_bionetwork,patch,Extend atlas names in hca_bionetwork,, | |||
There was a problem hiding this comment.
We should revisit what minor/patch updates are like. Thanks for following the guide https://github.com/HumanCellAtlas/metadata-schema/blob/master/docs/evolution.md#schema-versioning but I think extending an enumeration is not a patch change, as in my opinion any change in the schema that involves change in the validation rules should be at least a minor change. Anyways, this is good to go as per our specs! 🥇
NoopDog
requested changes
Oct 9, 2024
| "Eye", | ||
| "Brain" | ||
| ], | ||
| "Eye - Other", |
There was a problem hiding this comment.
You can remove "Eye - Other"; this will be refined as the atlas becomes more focused.
There was a problem hiding this comment.
Thank you, Dave! Done.
amnonkhen
approved these changes
Oct 10, 2024
hannes-ucsc
approved these changes
Oct 10, 2024
NoopDog
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
For
hca_bionetwork.jsonschema:hca_tissue_atlasExtend atlas names in the hca_bionetworks #1583
Reviews requested