Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enzymatic tissue dissociation fields #1599

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/jsonBrowser/type.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,11 @@ schema_type | The type of the metadata schema entity. | string | yes | | | pro
provenance | Provenance information provided by the system. | object | no | [See provenance](.md#provenance) | | |
protocol_core | Core protocol-level information. | object | yes | [See core protocol_core](core.md#protocol-core) | Protocol core | |
method | How cells or organelles were dissociated. | object | yes | [See module process_type_ontology](module.md#process-type-ontology) | Dissociation method | |
reagents | A list of purchased reagents used in this protocol. | array | no | [See module purchased_reagents](module.md#purchased-reagents) | Protocol reagents | |
reagents | A list of purchased reagents used in this protocol. | array | no | [See module purchased_reagents](module.md#purchased-reagents) | Purchased reagents | |
digestion_time | Time of digestion of the specimen. | integer | no | | Digestion time | | 2; 5; 10
digestion_time_unit | The unit in which the digestion time is expressed. | object | no | [See module time_unit_ontology](module.md#time-unit-ontology) | Digestion time unit | |
digestion_temperature | Temperature of digestion in Celsius or in general terms (i.e. cold, warm, room temperature). | string | no | | Digestion temperature | | 4; 37; cold
digestion_solution | Enzyme(s) or reagent(s) of the solution that was used for the digestion of the specimen. | array | no | | Digestion solution | Citric-acid based, Detergent-based, Lysis buffer, Collagenase, Collagenase A, Collagenase B, Collagenase complex, Collagenase D, Collagenase I, Collagenase II, Collagenase IV, Dispase, Dispase II, DNAse, DNAse I, Elastase, Liberase, Protease, Trypsin, Trypsin-like |

## iPSC induction protocol
_Information about how a biomaterial is treated to become an induced pluripotent stem cell._
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,56 @@
"type": "object",
"$ref": "module/process/purchased_reagents.json"
},
"user_friendly": "Protocol reagents"
"user_friendly": "Purchased reagents"
},
"digestion_time": {
"description": "Time of digestion of the specimen.",
"type": "integer",
"example": "2; 5; 10",
"user_friendly": "Digestion time"
},
"digestion_time_unit": {
"description": "The unit in which the digestion time is expressed.",
"type": "object",
"$ref": "module/ontology/time_unit_ontology.json",
"user_friendly": "Digestion time unit"
},
"digestion_temperature": {
"description": "Temperature of digestion in Celsius or in general terms (i.e. cold, warm, room temperature).",
"pattern": "\\d+(\\.\\d+)?|frozen|cold|room temperature|warm",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern must be anchored (And it should be grouped in order to properly capture alternative groups):

Suggested change
"pattern": "\\d+(\\.\\d+)?|frozen|cold|room temperature|warm",
"pattern": "^(\\d+(\\.\\d+)?|frozen|cold|room temperature|warm)$",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, things like "11frozen", "frozencold" will be accepted https://regex101.com/r/iRzCpr/1

"type": "string",
"example": "4; 37; cold",
"user_friendly": "Digestion temperature"
},
"digestion_solution": {
"description": "Enzyme(s) or reagent(s) of the solution that was used for the digestion of the specimen.",
"type": "array",
"items": {
"type": "string",
"enum": [
"Citric-acid based",
"Detergent-based",
"Lysis buffer",
"Collagenase",
"Collagenase A",
"Collagenase B",
"Collagenase complex",
"Collagenase D",
"Collagenase I",
"Collagenase II",
"Collagenase IV",
"Dispase",
"Dispase II",
"DNAse",
"DNAse I",
"Elastase",
"Liberase",
"Protease",
"Trypsin",
"Trypsin-like"
]
},
"user_friendly": "Digestion solution"
}
}
}
5 changes: 5 additions & 0 deletions json_schema/update_log.csv
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
Schema,Change type,Change message,Version,Date
type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed of user_friendly name of reagent field,,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed of user_friendly name of reagent field,,
type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed user_friendly name of reagent field,,

very very minor correction :)

type/protocol/biomaterial_collection/dissociation_protocol,minor,Added optional digestion_time field,,
type/protocol/biomaterial_collection/dissociation_protocol,minor,Added optional digestion_time_unit field,,
type/protocol/biomaterial_collection/dissociation_protocol,minor,Added optional digestion_temperature field,,
type/protocol/biomaterial_collection/dissociation_protocol,minor,Added optional digestion_solution field,,
Loading