Fixing a 'key' error and an import error #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo. Each completion (item) has 'annotations' not 'completions' . The code breaks with item['completions'] and works smooth with item['annotations'].
_LabelStudioMLBase_ could not be imported from _label_studio.ml_. Seeing a couple of other similar code examples on label-studio, I learned that import from _label_studio_ml.model_ works.
HAMZA310
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to reproduce the results in ner.py file, I had to fix two errors. One of them was a typo. Specifically, each completion (item) in fit method expects key 'annotations' (not 'completions') and that's what the author had intended.
The other fix I had to make was not so obvious. Specifically, I see an import error with LabelStudioMLBase and changing the module it was importing form fixed the error. I learned this by seeing a couple of other label-studio code examples.
I've not used bert.py file, and can't speak for these fixes in that file.