fix: LEAP-947: Check task when we get a response from ML (#5742)

Add a wrapper to check that we are going to apply response from ML-backend to the same task we sent a request from in a first place. --------- Co-authored-by: robot-ci-heartex <[email protected]>
HumanSignal · Apr 17, 2024 · b2fb581 · b2fb581
1 parent 91e2618
commit b2fb581
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 10 deletions.
diff --git a/web/apps/labelstudio/src/pages/DataManager/DataManager.js b/web/apps/labelstudio/src/pages/DataManager/DataManager.js
@@ -140,7 +140,20 @@ export const DataManagerPage = ({ ...props }) => {
           },
         });
 
-        lsf.loadSuggestions(suggestionsRequest, (response) => {
+        // we'll check that we are processing the same task
+        const wrappedRequest = new Promise(async (resolve, reject) => {
+          const response = await suggestionsRequest;
+
+          // right now task might be an old task,
+          // so in order to get a current one we need to get it from lsf
+          if (task.id === dataManager.lsf.task.id) {
+            resolve(response);
+          } else {
+            reject();
+          }
+        });
+
+        lsf.loadSuggestions(wrappedRequest, (response) => {
           if (response.data) {
             return response.data.result;
           }

diff --git a/web/dist/apps/labelstudio/main.css b/web/dist/apps/labelstudio/main.css
diff --git a/web/dist/apps/labelstudio/main.css.map b/web/dist/apps/labelstudio/main.css.map
diff --git a/web/dist/apps/labelstudio/main.js b/web/dist/apps/labelstudio/main.js
diff --git a/web/dist/apps/labelstudio/main.js.map b/web/dist/apps/labelstudio/main.js.map
diff --git a/web/dist/libs/editor/main.js b/web/dist/libs/editor/main.js
diff --git a/web/dist/libs/editor/main.js.map b/web/dist/libs/editor/main.js.map
diff --git a/web/libs/editor/src/stores/AppStore.js b/web/libs/editor/src/stores/AppStore.js
@@ -796,11 +796,18 @@ export default types
       self.suggestionsRequest = requestId;
 
       self.setFlags({ awaitingSuggestions: true });
-      const response = yield request;
 
-      if (requestId === self.suggestionsRequest) {
-        self.annotationStore.selected.setSuggestions(dataParser(response));
+      try {
+        const response = yield request;
+
+        if (requestId === self.suggestionsRequest) {
+          self.annotationStore.selected.setSuggestions(dataParser(response));
+          self.setFlags({ awaitingSuggestions: false });
+        }
+      } catch(e) {
         self.setFlags({ awaitingSuggestions: false });
+        // @todo handle errors + situation when task is changed
+        return;
       }
     });