Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add hiding resolved comments in CommentsOverlay #6542

Closed
wants to merge 2 commits into from
Closed

feat: Add hiding resolved comments in CommentsOverlay #6542

wants to merge 2 commits into from

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Oct 21, 2024 •
edited
Loading

This PR applies hiding comments icon in the CommentsOverlay when the comments is self are marked as resolved.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Which logical domain(s) does this change affect?

Comments, CommentsOverlay

@github-actions github-actions bot added the feat label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 038aa32
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6716dc6c4dde1c0008f03916

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 038aa32
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6716dc6cabfd41000854df8a

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

1 similar comment
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@Gondragos
Copy link
Collaborator Author

Gondragos commented Oct 21, 2024 •
edited by robot-ci-heartex
Loading

/git merge develop

Workflow run
Successfully merged: Already up to date.

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

1 similar comment
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@Gondragos
Copy link
Collaborator Author

Gondragos commented Oct 21, 2024 •
edited by robot-ci-heartex
Loading

/git merge develop

Workflow run
Successfully merged: Already up to date.

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@Gondragos Gondragos closed this Oct 22, 2024
@Gondragos
Copy link
Collaborator Author

This PR is ruined by the ruined follow merge

@Gondragos Gondragos deleted the fb-leap-1576 branch October 22, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gondragos @robot-ci-heartex