Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add hiding resolved comments in CommentsOverlay #6542

Closed
wants to merge 2 commits into from
Closed

feat: Add hiding resolved comments in CommentsOverlay #6542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acaaaac
feat: Add hiding resolved comments in CommentsOverlay
Gondragos Oct 21, 2024
038aa32
Try to rerun follow merge
Gondragos Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/libs/editor/src/components/InteractiveOverlays/CommentsOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const CommentItem: React.FC<CommentItemProps> = observer(({ comment, rootRef })
const node = comment.regionRef?.overlayNode;
// result is hidden when it's per-region and the region is not selected
const isHiddenResult = node?.area && !node.area.selected && !node.area.classification;
const isHidden = !node || node.hidden || isHiddenResult;
const isHidden = comment.isResolved || !node || node.hidden || isHiddenResult;
// {} !== {} it's always so, and it's a way to force re-render
const [forceUpdateId, forceUpdate] = useState<any>({});

Expand Down
Loading