feat: LEAP-1599: Allow to edit TimelineRegion spans #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `TimelineRegion` fields editable, but with new form to display the editor in this case — `start`/`end` are in the `ranges[0]`, not in region itself. New editor is pretty simple and reuses styles from both audio region and image region editors.
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Correct instant detection, correct distinguishing between start and end. The issue was that if lifespan is bigger than screen then start or end might not be rendered.
bmartel
reviewed
Nov 1, 2024
web/libs/editor/src/components/SidePanels/DetailsPanel/RegionEditor.tsx
Outdated
Show resolved
Hide resolved
bmartel
reviewed
Nov 1, 2024
web/libs/editor/src/components/SidePanels/DetailsPanel/RegionEditor.tsx
Outdated
Show resolved
Hide resolved
bmartel
approved these changes
Nov 1, 2024
|
/git merge
|
|
/git merge
|
MihajloHoma
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
TimelineRegionfields editable, but with new form to display the editor in this case —start/endare in theranges[0], not in region itself. New editor is pretty simple and reuses styles from both audio region and image region editors.Also added an icon for timeline spans.
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
Timeline spans can only be drawn within visible area and they can't be changed after. So we are adding ability to increase/change them at least via the start/end editable fields.
What alternative approaches were there?
Allow to change spans on timeline, but that's much more effort and more complex UX.
Does this PR introduce a breaking change?
What level of testing was included in the change?