Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LEAP-1599: Allow to edit TimelineRegion spans #6577

Merged
merged 12 commits into from
Nov 6, 2024
Merged

feat: LEAP-1599: Allow to edit TimelineRegion spans #6577

merged 12 commits into from
Nov 6, 2024

Commits on Oct 30, 2024

  1. feat: LEAP-1599: Allow to edit TimelineRegion spans 

    Make `TimelineRegion` fields editable, but with new form to display the editor in this case — `start`/`end` are in the `ranges[0]`, not in region itself.
New editor is pretty simple and reuses styles from both audio region and image region editors.
    @hlomzik
    hlomzik committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0b75db7 View commit details
    Browse the repository at this point in the history

  2. Add editable fields to MSTRegion type

    @hlomzik
    hlomzik committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0bae00c View commit details
    Browse the repository at this point in the history

  3. Fix linting

    @hlomzik
    hlomzik committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    34a036a View commit details
    Browse the repository at this point in the history

  4. Add styles for readonly duration in region editor

    @hlomzik
    hlomzik committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2dd5070 View commit details
    Browse the repository at this point in the history

  5. Improve styles for lifespan points 

    Correct instant detection, correct distinguishing between start and end.
The issue was that if lifespan is bigger than screen then start or end might not be rendered.
    @hlomzik
    hlomzik committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d9bc84b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'develop' into 'fb-leap-1599/edit-timeline-spans' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11673827398
    @hlomzik
    hlomzik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f39fe1f View commit details
    Browse the repository at this point in the history

  2. Fix loose any typings in 2 places

    @hlomzik
    hlomzik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    db342f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Add Icon for timeline regions

    @hlomzik
    hlomzik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c64bd9e View commit details
    Browse the repository at this point in the history

  2. Fix icon to fullscreen for now as it's more subtle

    @hlomzik
    hlomzik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    905eda0 View commit details
    Browse the repository at this point in the history

  3. Use better icon for timeline regions

    @hlomzik
    hlomzik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    05c697b View commit details
    Browse the repository at this point in the history

  4. Remove film.svg icon

    @hlomzik
    hlomzik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b9d53b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'develop' into 'fb-leap-1599/edit-timeline-spans' 

    Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11699585789
    @MihajloHoma
    MihajloHoma committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b1631db View commit details
    Browse the repository at this point in the history