You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to hide all related information in annotations:
User names and avatars are replaces with "Me" for current user and "User" for all other users.
This applies to comments, annotation history, annotation tabs, view all.
Annotation id is hidden (task id is shown though).
Dates are also hidden for now.
Technically it's done by passing new LSF interface annotations:hide-info and changing UI by condition.
Label Stream
Quick View with other users involved
It is advised to hide Data Manager for projects in such organizations.
PR fulfills these requirements
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
Product design
Backend (Database)
Backend (API)
Frontend
What alternative approaches were there?
Hide this data on backend — frontend solution is easier and good for now.
Also we could add styles just to hide some elements, but that would not allow us to replace text and would be harder to maintain.
Also we could dynamically change the data via Custom Scripts, but that's uncontrollable and unstable because of dynamic nature of this data.
What feature flags were used to cover this change?
No FFs, the feature is hidden behind org setting annotator_reviewer_firewall_enabled.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to hide all related information in annotations:
Technically it's done by passing new LSF interface
annotations:hide-info
and changing UI by condition.Label Stream
Quick View with other users involved
It is advised to hide Data Manager for projects in such organizations.
PR fulfills these requirements
Change has impacts in these area(s)
What alternative approaches were there?
Hide this data on backend — frontend solution is easier and good for now.
Also we could add styles just to hide some elements, but that would not allow us to replace text and would be harder to maintain.
Also we could dynamically change the data via Custom Scripts, but that's uncontrollable and unstable because of dynamic nature of this data.
What feature flags were used to cover this change?
No FFs, the feature is hidden behind org setting
annotator_reviewer_firewall_enabled
.Does this PR introduce a breaking change?