Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1515: Hide PII by condition #6544

Merged
merged 12 commits into from
Oct 30, 2024
Merged

feat: LEAP-1515: Hide PII by condition #6544

merged 12 commits into from
Oct 30, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 22, 2024

Allow to hide all related information in annotations:

  • User names and avatars are replaces with "Me" for current user and "User" for all other users.
  • This applies to comments, annotation history, annotation tabs, view all.
  • Annotation id is hidden (task id is shown though).
  • Dates are also hidden for now.

Technically it's done by passing new LSF interface annotations:hide-info and changing UI by condition.

Label Stream

Screenshot 2024-10-22 at 23 38 23

Quick View with other users involved

Screenshot 2024-10-22 at 23 35 50

It is advised to hide Data Manager for projects in such organizations.

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What alternative approaches were there?

Hide this data on backend — frontend solution is easier and good for now.
Also we could add styles just to hide some elements, but that would not allow us to replace text and would be harder to maintain.
Also we could dynamically change the data via Custom Scripts, but that's uncontrollable and unstable because of dynamic nature of this data.

What feature flags were used to cover this change?

No FFs, the feature is hidden behind org setting annotator_reviewer_firewall_enabled.

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

With new LSF interface `annotations:hide-info` hide all personal info about users and annotation, including ids and dates.
It should be visually connected with labeling area
@github-actions github-actions bot added the feat label Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 713ff18
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6721e401339d6c000827f1ee

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 713ff18
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6721e401339d6c000827f1ec

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 24, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/relations/audio.cy.ts

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 24, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/apps/labelstudio/src/pages/DataManager/api-config.example.js

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 24, 2024

/git merge

Workflow run
Successfully merged: Already up to date.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 28, 2024

/git merge

Workflow run
Successfully merged: 16 files changed, 145 insertions(+), 48 deletions(-)

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Oct 29, 2024

/git merge

Workflow run
Successfully merged: 4 files changed, 24 insertions(+), 4 deletions(-)

@hlomzik hlomzik enabled auto-merge (squash) October 30, 2024 01:33
@hlomzik hlomzik merged commit b8038e8 into develop Oct 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants