feat: block sentry in frontend side #6615
Open
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
bmartel
reviewed
Nov 8, 2024
| setTags(); | ||
| Sentry.init({ | ||
| dsn: "https://[email protected]/5838868", | ||
| dsn: APP_SETTINGS.frontend_sentry_dsn, |
There was a problem hiding this comment.
Suggested change
| dsn: APP_SETTINGS.frontend_sentry_dsn, | |
| dsn: APP_SETTINGS.sentry_dsn, |
The value as set in the template is sentry_dsn not frontend_sentry_dsn.
bmartel
reviewed
Nov 8, 2024
| @@ -5,10 +5,10 @@ import { Integrations } from "@sentry/tracing"; | |||
| import { Route } from "react-router-dom"; | |||
|
|
|||
| export const initSentry = (history: RouterHistory) => { | |||
| if (APP_SETTINGS.debug === false) { | |||
| if (APP_SETTINGS.debug === false && APP_SETTINGS.frontend_sentry_dsn) { | |||
There was a problem hiding this comment.
Suggested change
| if (APP_SETTINGS.debug === false && APP_SETTINGS.frontend_sentry_dsn) { | |
| if (APP_SETTINGS.debug === false && APP_SETTINGS.sentry_dsn) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
#4421
In airgapped environment, frontend tries to get the file from sentry cdn, but it hangs, so page won't load.
Setting
FRONTEND_SENTRY_DSNwon't fix this problemn.What does this fix?
When
FRONTEND_SENTRY_DSNis set empty,it disables
Does this PR introduce a breaking change?
(check only one)