Skip to content

Conversation

yyassi-heartex
Copy link
Contributor

This pull request improves the handling of the Agreement filter dropdown in the data manager table. The main focus is to ensure that the dropdown closes automatically after saving changes and to provide a way for the header cell to trigger closing the dropdown.

Dropdown behavior improvements:

  • Added an onClose callback to AgreementSelected.HeaderCell, allowing the header cell to close the dropdown when needed. [1] [2]
  • Updated the onSave handler in TableHead.jsx to automatically close the dropdown after saving agreement filters.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner October 2, 2025 18:39
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit eec9be0
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68dfe0c1cc85f60008fb529d

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit eec9be0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68dfe0c14e6bc900081a0cfb
😎 Deploy Preview https://deploy-preview-8575--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Oct 2, 2025
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit eec9be0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68dfe0c1d19fa50008dd626f

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit eec9be0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68dfe0c1581b7300080b1c8d
😎 Deploy Preview https://deploy-preview-8575--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.45%. Comparing base (841a30b) to head (eec9be0).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8575   +/-   ##
========================================
  Coverage    67.45%   67.45%           
========================================
  Files          780      780           
  Lines        59913    59913           
  Branches     10154    10154           
========================================
+ Hits         40413    40416    +3     
+ Misses       19497    19494    -3     
  Partials         3        3           
Flag Coverage Δ
lsf-e2e 54.81% <ø> (+<0.01%) ⬆️
lsf-integration 51.29% <ø> (ø)
lsf-unit 8.61% <ø> (ø)
pytests 79.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner October 2, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant