Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge commit #1

Merged
merged 720 commits into from
Oct 23, 2023
Merged

Merge commit #1

merged 720 commits into from
Oct 23, 2023

Conversation

HunsupJung
Copy link
Owner

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

bzbarsky-apple and others added 30 commits September 29, 2023 02:49
@bzbarsky-apple
Split out CHIPErrror into a separate source set. (#29494)
9dee693 
* Split out CHIPErrror into a separate source set.

CHIPError.cpp uses ErrorStr.h, so ErrorStr gets moved into the same source set.

ErrorStr.cpp did not actually use CodeUtils.h for anything except including
ErrorStr.h.

The random whitespace changes are because we changed our clang-format version
but then did not restyle the tree.

* Address review comment.
@ksperling-apple
Restyle C(++) code after upgrade to clang-format 16 (#29496)
38d6a48 
This is a follow-up to #29447 and should really have been done as part of that PR.
@bzbarsky-apple
Fix Darwin availability bits for command payloads: (#29468)
42957dc 
1) Add missing isForCommandPayload=true to declarations of the old command
   payload names.  Otherwise we were ending up with SetUtcTime being marked
   provisional, which is not backwards-compatible.
2) We need to declare fields in the old-name command payloads with the right
   availability, since the availability in the super-class is "too new".  The
   implementation then needs to use @dynamic.  This is similar to how structs
   work.
3) SetUTCTime cannot be provisional (and hence unavailable) if SetUtcTime is
   supposed to be available and inherits from it.  This requires exposing
   SetUTCTime and its fields in the first release where we will update
   Matter.framework in the Xcode SDK to the setup where we started doing
   "provisionally available".

Items 1 and 2 are handled by using "completeDecl" for both the old and new name.
@ksperling-apple
Darwin: Refactor MTRAsyncWorkQueue to avoid retain cycles (#29464)
433e676 
* Darwin: Refactor MTRAsyncWorkQueue to avoid retain cycles

- Pass a completion to readyHandler instead of capturing the work item
- Hold the context weakly within the queue and handle context loss
- Simplify thread-safety by having clear ownership rules for work items

* Darwin: Consolidate MTRAsyncWorkQueue headers

The internal header is no longer needed because MTRAsyncWorkQueue is entirely
private to the project now. Also tidy up duplicate / batching logic a little.

* Darwin: invalidate MTRDevice work queue

* Address review comments

* Add os_unfair_lock_assert_owner and comments

* Introduce MTRAsyncWorkItemRetryCountBase

* More tweaks from review
@cecille @restyled-commits
Fix constexpr complaints on test vectors (#29462)
f5f2e51 
* Fix constexpr complaints on test vectors

* Attempt #2 - separate PAAs used in non-test

* Things work better when we add all the files

* Restyled by whitespace

* Restyled by clang-format

* add tokenizer

* add the gni

* add pigweed import

* Change filenames

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
@yunhanw-google
remove STM32CubeWB from android build (#29499)
4a9dab1
@sharadb-amazon
tv-casting-app docs: Marked code with triple backticks (#29497)
90ec279
@erwinpan1
Add mismodified nrfconnect CMakeLists in #29436 (#29502)
9a5b1c1
@DamMicSzm
[Tizen] Convert possible glib objects to GAutoPtr<> (#29488)
da0f9e3 
* Replace glib char with GAutoPtr<char> in BLEManagerImpl.cpp

* Replace glib char with GAutoPtr<char> in DnssdImpl.cpp

* Replace glib char with GAutoPtr<char> in WiFiManager.cpp

* Add GSource to GLibTypeDeleter.h

* Replace glib GSource with GAutoPtr<GSource> in ChipDeviceScanner.cpp

* Replace glib GSource with GAutoPtr<GSource> in DnssdImpl.cpp

* Replace glib GSource with GAutoPtr<GSource> in PlatformManagerImpl.cpp

* Review update
@tehampson
yamltest: chip-repl: Make commissioning DUT flag more correct (#29473)
8ca75ad
@tehampson
Remove include_yamltests arg, and always install the whl for python t…
d405985 
…ests (#29456)

* Remove include_yamltests arg, and install always for python tests

* CI fixes

* CI fixes
@tx2rx @asriot
[ASR] Bump asr582x sdk to v1.9.0 (#29424)
54b2f94 
Co-authored-by: weicheng <[email protected]>
@jtung-apple
[Darwin] MTRBaseSubscriptionCallback mInterimReportBlock should be ca…
7a85f83 
…ncelled and nil-ed sooner for OnError case (#29500)
@hicklin @restyled-commits
Bugfix: rvc app docked and charging state remain true (#29257)
6bd473d 
* Enabled the RvcClean StartUpMode attribute in the zap and mettar files.

* Updated the PICS files to note that this device supports testing the StartUpMode attribute for the RVC Clean cluster.

* Refactored the run_all_yaml script.

* Updated the testing section of the readme to include the test case related to the RvcClean StartUpMode.

* Restyled by prettier-markdown

* Restyled by shfmt

* Fixed bug that was causing the charging and docked states to remain true once set.

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
@andy31415 @andreilitvin
Switch compileSdkVersion to 31 in remaining gradle files (#29512)
712d1ec 
Co-authored-by: Andrei Litvin <[email protected]>
@cecille
TC-IDM-10.1: Delete yaml (#29493)
3f6ef59 
This test has a python implementation and the yaml is no longer
required. It does nothing anyway.
@s07641069
[Telink] Disable not used shell modules (#29486)
bc9f42e 
* [Telink] Disable not used shell modules

* [Telink] restore default shell stack size after tests with light-switch
@andy31415 @andreilitvin
Remove top-level struct and enum support from IDL processing (#29511)
8cb1bda 
* Start removing enums and structs from top level definitions in the parser

* Remove top level structs from matter idl auto-generation

* Fix generator type logic

* Update test inputs to move global structs

* Fix unit tests

* Restyle

* Remove unused import

---------

Co-authored-by: Andrei Litvin <[email protected]>
@jrhees-cae @restyled-commits
[TC-DRLK-2.4] Handle DUT's that do not support USR & PIN features (#2…
48d4d43 
…9372)

* [TC-DRLK-2.4] Handle DUT's that do not support USR & PIN features

Fixes CHIP-Specifications/chip-test-plans#3461

* Zap regen

* Restyled by prettier-yaml

---------

Co-authored-by: Restyled.io <[email protected]>
@yunhanw-google
correctly clean output from android build (#29516)
cd6f5b0
@manjunath-grl @restyled-commits
Fix YAML script issues (#29339)
a40b53c 
* Fix script issue: 649, 650, 651, 652, 653, 654,
Modified tests:
TC_ACL_2_10
TC_ACL_2_7
TC_ACL_2_8
TC_DGWIFI_3_2_Simulated
TC_FLW_2_1
TC_LUNIT_3_1
TC_RH_2_1
TC_SC_4_1
Automated test:
TC_RVCCLEANM_3_3
Semi-automated tests:
TC_REFALM_2_1
Fixes issue: 29331

* Auto generated files

* The following YAMLs are removed
 since there are Python script for the testcases.
TC-DT-1.1
TC-IDM-10.1
TC-IDM-11.1
TC-SM-1.1
TC-SM-1.2

* Fixes issue: 656 & 658
Modified tests:
TC-GRPKEY-2.1
Removed test:
TC-LVL-2.3_Simulated

* Modified testcase TC-SC-5.1

* Fixes issue: 655, 660
Modified tests:
TC-ACL-2.4
TC-ACL-2.5
TC-ACL-2.6
TC-ACL-2.7
TC-SC-5.2
Revert back the DGGEN-2.1 testcase

* Modified test FLW-2.1

* Fixes YAML script issue: 664, 668, 671, 672, 673
TC-DGGEN-2.1
TC-TSTAT-1.1
TC-TSUIC-1.1
TC-TSTAT-2.1
TC-WNCV-3.4
TC-WNCV-3.5
Manual tests:
TC-REFALM-2.2
TC-REFALM-2.3

* Restyled by whitespace

* Fixes issue 984
TC-TCTL-1.1

* Reverted back changes for tests:
TC-DGGEN-2.1
TC-REFALM-2.1
TC-RVCCLEANM-3.3

* Modify ciTest.json file

* Fix type

---------

Co-authored-by: Restyled.io <[email protected]>
@s07641069
[Telink] Update Docker image (Zephyr update) (#29528)
d7a9833
@dependabot
Bump third_party/libwebsockets/repo from 7ef2065 to 4144c1e (#29522)
e645c7c 
Bumps [third_party/libwebsockets/repo](https://github.com/warmcat/libwebsockets) from `7ef2065` to `4144c1e`.
- [Commits](warmcat/libwebsockets@7ef2065...4144c1e)

---
updated-dependencies:
- dependency-name: third_party/libwebsockets/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump third_party/openthread/repo from f0530af to eaa6261 (#29524)
3f891a7 
Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `f0530af` to `eaa6261`.
- [Release notes](https://github.com/openthread/openthread/releases)
- [Commits](openthread/openthread@f0530af...eaa6261)

---
updated-dependencies:
- dependency-name: third_party/openthread/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump third_party/mbedtls/repo from b53e630 to da635ab (#29527)
7013b09 
Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `b53e630` to `da635ab`.
- [Release notes](https://github.com/ARMmbed/mbedtls/releases)
- [Commits](Mbed-TLS/mbedtls@b53e630...da635ab)

---
updated-dependencies:
- dependency-name: third_party/mbedtls/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andy31415 @andreilitvin @bzbarsky-apple
Remove usage of __has_include and usage of USE_ZAP_CONFIG (#29492)
4fa3721 
* Start removing split defines and setups for InitDataModelHandler

* Restyle

* Add EmptyDataModelHandler to Matter.framework.

---------

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
@andy31415
Remove some unused CIPD packages before android compile. (#29530)
188cf7d 
This should save about 2.5GB of space.
Ideally we should not download these in the first place,
however I would have to figure out how to set that up.

For now tested locally that compile seems to pass because we
use the NDK, however CI will fully validate this.
@s07641069 @andriy-bilynskyy @mishadesh
[Telink] Use common Zephyr heap & Update Telink image to 16 (#29531)
6047fbb 
* [Telink] Use common Zephyr heap

* [Telink] Added default RF TX power selection

* [Telink] Update Telink image to 16

---------

Co-authored-by: Andrii Bilynskyi <[email protected]>
Co-authored-by: Misha Tkachenko <[email protected]>
@dependabot
Bump third_party/imgui/repo from f4790f6 to a614387 (#29532)
199b155 
Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `f4790f6` to `a614387`.
- [Release notes](https://github.com/ocornut/imgui/releases)
- [Commits](ocornut/imgui@f4790f6...a614387)

---
updated-dependencies:
- dependency-name: third_party/imgui/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rcasallas-silabs
Silabs: RTT I/O stream support added. (#29452)
7c216f8
@HunsupJung HunsupJung merged commit aef8792 into HunsupJung:master Oct 23, 2023
56 of 58 checks passed
HunsupJung pushed a commit that referenced this pull request Oct 23, 2023
@bzbarsky-apple @HunsupJung
Fix intermittent LSan failures running "darwin-framework-tool tests l…
d10570d 
…ist". (project-chip#29666)

The typical failure there looks like this:

==29620==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12)
    #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789)
    #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db)
    project-chip#3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa)
    project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8)
    project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1)
    project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44)
    project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343)
    project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992)
    project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7)
    project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894)
    project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e)
    project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac)
    project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25)
    project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2)
    project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6)
    project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603)
    project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81)
    project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659)
    project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d)
    project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c)
    project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app ble config controller core crypto darwin docker documentation Improvements or additions to documentation esp32 examples github gn icd inet integrations lib linux lwip platform scripts shell support tests tizen tools vscode workflows zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.