feat: remove automatically inspect primary key

HuolalaTech · Oct 12, 2023 · ba16dc2 · ba16dc2
1 parent 400d7f8
commit ba16dc2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/src/createBaseQuery.ts b/src/createBaseQuery.ts
@@ -21,29 +21,12 @@ type QueryBaseHookOptions = Omit<
   variables?: any
 }
 
-const existedPrimaryKeys = new Set<string>()
-
 export const createBaseQuery = (
   defaultOptions: any,
   useRQHook: (options: any, queryClient?: any) => any,
   overrideOptions?: QueryBaseHookOptions
 ): any => {
-  const {
-    primaryKey,
-    queryFn,
-    queryKeyHashFn,
-    getPreviousPageParam,
-    getNextPageParam,
-    initialPageParam,
-  } = defaultOptions as CreateBaseQueryOptions
-
   if (process.env.NODE_ENV !== 'production') {
-    if (existedPrimaryKeys.has(primaryKey)) {
-      console.error(`[Bug] Duplicated primaryKey: ${primaryKey}`)
-    } else {
-      existedPrimaryKeys.add(primaryKey)
-    }
-
     // @ts-ignore
     if (defaultOptions.useDefaultOptions) {
       console.error(
@@ -52,6 +35,15 @@ export const createBaseQuery = (
     }
   }
 
+  const {
+    primaryKey,
+    queryFn,
+    queryKeyHashFn,
+    getPreviousPageParam,
+    getNextPageParam,
+    initialPageParam,
+  } = defaultOptions as CreateBaseQueryOptions
+
   const getPrimaryKey = () => primaryKey
 
   const getKey = (variables?: any) => getQueryKey(primaryKey, variables)

diff --git a/src/utils.ts b/src/utils.ts
@@ -39,6 +39,7 @@ export const suspenseOptions = {
   enabled: true,
   suspense: true,
   throwOnError: true,
+  // Compatible with ReactQuery v4
   useErrorBoundary: true,
 }