Speed up and simplify geography functions with geopandas #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used the geopandas method from
get_basin
for the_get_natural_earth_feature
function used by other functions ingeography
, which gives a substantial speed up.I simplified the
sjoin
statement a bit by usingpredicate=contains
, so you don't need the reset_index/groupby/first statements, which also gives a good speed upget_basin
now uses _get_natural_earth_feature because it is the same code now