Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Define the user roles #195

Merged
merged 2 commits into from
Jan 30, 2021
Merged

[Doc] Define the user roles #195

merged 2 commits into from
Jan 30, 2021

Conversation

Huy-Ngo
Copy link
Owner

@Huy-Ngo Huy-Ngo commented Jan 30, 2021

Expectedly resolve #192

The rendered table looks ugly due to word breaking tho.

@Huy-Ngo Huy-Ngo added the documentation Improvements or additions to documentation label Jan 30, 2021
@Huy-Ngo Huy-Ngo marked this pull request as draft January 30, 2021 09:01
@Huy-Ngo
Copy link
Owner Author

Huy-Ngo commented Jan 30, 2021

Hmm I think I should add the inheritance model here too.

@Huy-Ngo
Copy link
Owner Author

Huy-Ngo commented Jan 30, 2021

Eh... that model is not implemented anyway... should we include that?

@McSinyx
Copy link
Collaborator

McSinyx commented Jan 30, 2021

As Raymond Hettinger once said, inheritance is for code reuse, and we do reuse code handling students and supervisors (in other words, there are places where they're treated the same). What you wrote described that well enough so I'm not sure what you planned to add.

@Huy-Ngo
Copy link
Owner Author

Huy-Ngo commented Jan 30, 2021

What you wrote described that well enough so I'm not sure what you planned to add.

I planned to add the UML for it, i.e. this one

UML Diagram

By the way, since judge and supervisor can be the same person (though for different projects), what are we gonna do about it?

Btw I'm gonna squash this PR
@McSinyx
Copy link
Collaborator

McSinyx commented Jan 30, 2021

since judge and supervisor can be the same person (though for different projects), what are we gonna do about it?

I'd suggest adding a field judges to project which is differently invited (i.e. separate invite member from invite judge).

@Huy-Ngo
Copy link
Owner Author

Huy-Ngo commented Jan 30, 2021

I think judge can be added by the faculty's assistant.

@Huy-Ngo Huy-Ngo marked this pull request as ready for review January 30, 2021 09:45
@Huy-Ngo
Copy link
Owner Author

Huy-Ngo commented Jan 30, 2021

Referenced in #197

@Huy-Ngo Huy-Ngo merged commit 502807f into main Jan 30, 2021
@Huy-Ngo Huy-Ngo deleted the def-users branch January 30, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe the user roles more comprehensively
2 participants