Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define client-initiated pagination #184
Define client-initiated pagination #184
Changes from all commits
3d49d3a
fbca986
c676464
c27deef
a6c54dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only me or
pageReference
still does not make much sense? Can't we just go withoffset
,limit
andpageIndex
for now and create another issue or PR before we add it to the vocab.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't like to limit possible usages only to numeric pages - that's why
pageIndex
. I've recently added asubPropertyOf
relation betweenpageIndex
andpageReference
- it feels natural this way.Both predicates has similar semantics - here client you can point to a specific page of the set. The extra thing that comes with
pageIndex
is it's cleanness, which covers most use cases.While it is not possible to provide i.e. min/max range or other means of expressing allowed values for
pageReference
, this predicate still can be used as it is now with some success.