Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): URQL #2

Merged
merged 38 commits into from
Jan 21, 2025
Merged

feat(mobile): URQL #2

merged 38 commits into from
Jan 21, 2025

Conversation

lorenjohnson
Copy link
Member

@lorenjohnson lorenjohnson commented Oct 8, 2024

⚠️ URQL CONVERSION IN PROGRESS

Major Functional Areas Still needing URQL

  • Sign-up flow (partially converted, needs testing)
  • Sockets conversion
  • ItemChoosers...
  • PostBodyProposal?
  • AnalyticsEvents (search TODO: URQL - analytics)

Then...

  • Remove any remaining unused Redux/ReduxORM setup
  • Final reviews (graphql and hooks organization)
  • Move apps/mobile/src/urql-shared|graphql into shared folders for Web conversion
  • Test, test, test
  • Add tests 🥹

Currently Known Issues

  • URQL updaters and optimistic updates ... Been hard to solve. May be necessary for Comment and Message creation to not be too slow

@lorenjohnson lorenjohnson self-assigned this Oct 8, 2024
Copy link

gitguardian bot commented Oct 8, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lorenjohnson lorenjohnson changed the base branch from main to dev October 11, 2024 20:28
@lorenjohnson lorenjohnson marked this pull request as draft November 21, 2024 23:14
@lorenjohnson lorenjohnson added this to the Mobile: URQL Re-write milestone Nov 22, 2024
…tc to better match URQL useQuery/useMutation signature
@lorenjohnson lorenjohnson merged commit d86d650 into dev Jan 21, 2025
1 of 3 checks passed
@lorenjohnson lorenjohnson deleted the urql-poc branch January 21, 2025 09:22
@thomasgwatson
Copy link
Collaborator

Did you say that ModerationActions needed to be converted? It looks like you've already switched them over to useMutation.

@lorenjohnson
Copy link
Member Author

Did you say that ModerationActions needed to be converted? It looks like you've already switched them over to useMutation.

Things are converted but untested. Same goes for any Home Welcome/Home Welcome Check stuff, which would be another good area for you to jump in on.

Of course this particular branch on the PR you are commenting on is merged to dev and there is lots more done. Branch from dev, or this branch #159, as it has some important fixes that are not yet merged to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants