Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21 context menu backend #48

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

21 context menu backend #48

wants to merge 12 commits into from

Conversation

thomasgwatson
Copy link
Collaborator

This is just the backend for #21

I'm wary of continuing to write out a massive feature branch, with changes to backend, mobile and web, without some level of periodic merging of code into dev. Just going to set us up for massive merge conflicts, particularly once we start re-structuring existing parts of the platform (chat's backend comes to mind).

This change-set is safe to merge. There are still backend changes required, but I want to now focus on web UI changes

Backend changes I am still anticipating:

  • adapting to the new chat data model
  • Data migration from old context menu to new (There is a Group method that does this but no overall process to apply it across the platform)
  • Functions to determine activity metrics for each widget/view (highlightNumber and secondaryNumber). What these numbers represent aren't specced out fully yet, and will likely require different rules for different types of views
  • process to check if content/group creation requires changes to the groups context menu (most of this logical is covered by transitionToNewMenu function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant