Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve macOS build workflows #1218

Merged
merged 3 commits into from
Jan 22, 2025
Merged

[CI] Improve macOS build workflows #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fdff8
[CI] Update macOS builds
flavioislima Jan 22, 2025
2065299
chore: filename
flavioislima Jan 22, 2025
717e3df
chore: workflow name
flavioislima Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-mac-arm64.yml → .github/workflows/build-mac-x64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build mac arm64
name: Build mac x64

on:
workflow_dispatch:
Expand All @@ -9,8 +9,8 @@ env:
RUDDERSTACK_CLIENT_ID: ${{ secrets.RUDDERSTACK_CLIENT_ID }}

jobs:
release-mac-arm64:
runs-on: macos-latest-xlarge
release-mac-x64:
runs-on: macos-13

steps:
- name: Checkout code
Expand All @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
- uses: pnpm/action-setup@v3
with:
standalone: ${{ runner.os == 'Windows' }}
Expand All @@ -43,6 +43,6 @@ jobs:
echo "VITE_IPFS_API=${{ secrets.VITE_IPFS_API }}" >> .env

- name: Build artifacts.
run: pnpm release:mac:arm64
run: pnpm release:mac:x64
env:
NOTARIZE: true
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ jobs:
run: pnpm dist:linux:ci:rpm
- name: Build pacman artifact
run: pnpm dist:linux:ci:pacman
build_mac_x64:
runs-on: macos-13
build_mac_arm64:
runs-on: macos-latest
concurrency:
group: build-mac-x64-${{ github.ref }}
group: build-mac-arm64-${{ github.ref }}
cancel-in-progress: true
steps:
- name: Checkout repository.
Expand Down Expand Up @@ -127,14 +127,14 @@ jobs:
echo "VITE_LD_ENVIRONMENT_ID=${{ secrets.VITE_LD_ENVIRONMENT_ID_TEST }}" > .env
echo "VITE_IPFS_API=${{ secrets.VITE_IPFS_API }}" >> .env
- name: Build artifacts.
run: pnpm run dist:mac:x64
run: pnpm run dist:mac:arm64
env:
NOTARIZE: false
- name: Upload Intel build.
uses: actions/upload-artifact@v4
with:
name: mac-dmg-x64
path: dist/HyperPlay*x64.dmg
name: mac-dmg-arm64
path: dist/HyperPlay*arm64.dmg
retention-days: 7
if-no-files-found: error
compression-level: 3
2 changes: 1 addition & 1 deletion .github/workflows/release_macOS.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
if-no-files-found: error

release-arm64:
runs-on: macos-latest-xlarge
runs-on: macos-latest

steps:
- name: Checkout code
Expand Down
Loading