Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/achievements #606

Merged
merged 116 commits into from
Dec 18, 2023
Merged

Feat/achievements #606

merged 116 commits into from
Dec 18, 2023

Conversation

andrewpjames13
Copy link
Contributor

@andrewpjames13 andrewpjames13 commented Oct 24, 2023 •
edited by BrettCleary
Loading

Steps to test

  1. Set ACHIEVO_API_KEY env var with export ACHIEVO_API_KEY=...
  2. Set SHOW_ACHIEVEMENTS env var with export SHOW_ACHIEVEMENTS=true
  3. Get your steam id by following https://help.steampowered.com/en/faqs/view/2816-BE67-5B69-0FEC
  4. Enter your steam id in settings
    image
  5. Navigate to the achievements page using the left sidebar

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

BrettCleary and others added 30 commits September 28, 2023 21:47
@BrettCleary
add getAchievements with mock json
00fc3fa
@BrettCleary
prettier
cc14757
@blackstock
WIP: rought in front end components
39d239b
@blackstock
chore: prettier
5f57616
@blackstock
chore: yarn lock
0181aeb
@blackstock
wip: add type to mocked data
ecdac29
@andrewpjames13
wip: consume mock data
61d7928
@andrewpjames13
wip: wire up handle add and put in mock timeout for handling mint
765b64e
@BrettCleary
add props to summary, add individual achievement api method
6e1e94f
@andrewpjames13
chore: render test data until api returns correct types
e22cda2
@andrewpjames13
Merge branch 'feat/achievements' of https://github.com/HyperPlay-Gami…
1884ae5 
…ng/hyperplay-desktop-client into feat/achievements
@andrewpjames13
chore: dont use real data just yet
dff3401
@andrewpjames13
feat: add pagination, fliters and sort
e252daf
@andrewpjames13
chore: prettier
abeab29
@andrewpjames13
feat: update achievements submodule
fbcc01e
@andrewpjames13
feat: update achievements api
570ad68
@andrewpjames13
feat: allow filters and sort to make api call
267b713
@andrewpjames13
chore: pull achievement layout out into parent route
ae3b2b9
@andrewpjames13
wip: add game achievements page
9ad290e
@andrewpjames13
feat: add pagination and sorting to getIndividualAchievemnts
8a8a4fa
@andrewpjames13
feat: add data for achievement stats
399209c
@andrewpjames13
chore: prettier
f78e335
@andrewpjames13
feat: allow mint selection to persist across achievement pages
1d0d934
@andrewpjames13
fix: prettir
cdfc746
@andrewpjames13
fix: lint
8841a16
@andrewpjames13
chore: update sub module branch
121a88b
@andrewpjames13
chore: remove getGame function
8e8e2e1
@andrewpjames13
chore: move freeMints into stats
1410a3f
@andrewpjames13
chore: prettier
a71c1b0
@andrewpjames13
chore: update to numFreeMints
b8a862b
@BrettCleary
Copy link
Collaborator

@red-game-dev just to clarify also. this is what happens when the requests fail to get achievements so it is not without error handling

image

@red-game-dev
Copy link
Contributor

@red-game-dev just to clarify also. this is what happens when the requests fail to get achievements so it is not without error handling

Oh awesome! Thats good, will continue the review & tests

While at it, how to obtain an achievo API key ?

@BrettCleary
Copy link
Collaborator

I also noticed an issue on the first render of the achievements page after setting steam id. I believe this is at least partially caused by this issue #681 as on subsequent launches without this error, it does not occur

eliobricenov
eliobricenov approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geeez that AchievementState is a beast 😮‍💨

great work ser I only have one minor comment

src/frontend/screens/Achievements/index.tsx Outdated Show resolved Hide resolved
red-game-dev
red-game-dev approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@red-game-dev red-game-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else to say other than, wonderful work! Epic work man! 🙌

@nyghtstalker
Copy link

  1. The initial setup does load the games on the right side. Switching to DES does load the games but then going back to ASC reverts to the Oops page.

image

image

  1. "Free Mints" is missing in the game pages

image

  1. Changing the Steam ID and returning to the page updates the numbers but the games are still displayed and accessible.

image

@BrettCleary
Copy link
Collaborator

these are fixed now @nyghtstalker

Just needed to clear the cache on steam id set

nyghtstalker
nyghtstalker approved these changes Dec 18, 2023
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed! Ship it!

@BrettCleary BrettCleary merged commit 188b2ac into main Dec 18, 2023
13 of 16 checks passed
@BrettCleary BrettCleary deleted the feat/achievements branch December 18, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@red-game-dev red-game-dev red-game-dev approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@BrettCleary BrettCleary BrettCleary approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima

Assignees
No one assigned
Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andrewpjames13 @BrettCleary @pimentel08 @red-game-dev @nyghtstalker @eliobricenov @blackstock