-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix macOS release workflow #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a regression of #574
|
||
jobs: | ||
release-mac-arm64: | ||
runs-on: macos-latest-xlarge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this m1 runner because we compile to bytecode and the bytecode has to be compiled on the same arch that it will be distributed for #574
- name: Upload ARM build. | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: mac-arm64 | ||
path: dist/HyperPlay*arm64.dmg | ||
retention-days: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't compile arm builds on macos-latest
@@ -83,6 +48,6 @@ jobs: | |||
run: echo "VITE_LD_ENVIRONMENT_ID=${{ secrets.VITE_LD_ENVIRONMENT_ID }}" > .env.production | |||
|
|||
- name: Build artifacts. | |||
run: yarn release:mac:arm64 | |||
run: yarn release:mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can compile intel builds on this arm runner macos-latest-xlarge
because of the bytecode issue #574
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try since it is being 5 months since the change.
I will modify the other file to see how it will work.
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need these commands separated to address the bytecode errors fixed on #574
I am closing this PR since it wont work like Brett said due to the bytecode. |
Closes #732
Fix the issue with the intel release overwriting the arm64 one by keeping one latest-mac.yml file only.
Use the following Checklist if you have changed something on the Backend or Frontend: