feat: add active wallet integration #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eliobricenov
changed the title
eliobricenov
commented
Jan 24, 2025
Comment on lines
+19
to
+44
| // 1. Get projectId from https://cloud.reown.com | ||
| const projectId = '878099c5ebd1a07a3785ec7ebee59ba6' | ||
|
|
||
| // 3. Set the networks | ||
| const networks = [mainnet] | ||
|
|
||
| // 4. Create Wagmi Adapter | ||
| const wagmiAdapter = new WagmiAdapter({ | ||
| networks, | ||
| projectId, | ||
| ssr: true | ||
| }) | ||
|
|
||
| // 5. Create modal | ||
| createAppKit({ | ||
| adapters: [wagmiAdapter], | ||
| networks: [mainnet], | ||
| projectId, | ||
| themeMode: 'dark', | ||
| features: { | ||
| email: false, | ||
| socials: false, | ||
| onramp: false, | ||
| analytics: false | ||
| } | ||
| }) |
There was a problem hiding this comment.
this is to add appkit to storybook, not to the quest-ui package itself
BrettCleary
approved these changes
Jan 27, 2025
Comment on lines
10
to
62
| function InfoAlert({ | ||
| title, | ||
| children | ||
| }: { | ||
| title: string | ||
| children: React.ReactNode | ||
| }) { | ||
| return ( | ||
| <div className={styles.newWalletDetectedContainer}> | ||
| <div className={styles.infoIconContainer}> | ||
| <Images.Info className={styles.infoIcon} /> | ||
| </div> | ||
| <div className={styles.infoTextContainer}> | ||
| <span className="title-sm">{title}</span> | ||
| <div>{children}</div> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| function InputLikeBox({ | ||
| children, | ||
| className | ||
| }: { | ||
| children: React.ReactNode | ||
| className?: string | ||
| }) { | ||
| return ( | ||
| <div className={cn(styles.inputLikeContainer, className)}> | ||
| <div className={styles.walletContainer}> | ||
| {children} | ||
| <Images.Wallet className={styles.walletIcon} /> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| function InputLikeContainer({ | ||
| children, | ||
| className, | ||
| title | ||
| }: { | ||
| children: React.ReactNode | ||
| className?: string | ||
| title: string | ||
| }) { | ||
| return ( | ||
| <div className={cn(styles.container, className)}> | ||
| <span className={cn(styles.label, 'caption')}>{title}</span> | ||
| <div>{children}</div> | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
I would be in favor of breaking these out into separate components
| ) | ||
| } | ||
|
|
||
| if (hasDifferentWallets) { |
There was a problem hiding this comment.
should this condition be hasDifferentWallets && hasNotSignedWithDifferentWallet?
i.e. if I
- connect 0x123
- set gameplay wallet to 0x123
- switch to 0x444
- set gameplay wallet to 0x444
- switch back to 0x123
It shouldn't ask me to sign again right?
There was a problem hiding this comment.
good call. I need to add this UX
| @@ -0,0 +1,7 @@ | |||
| export function truncateEthAddress(address: string, digits = 6) { | |||
There was a problem hiding this comment.
might be a good hp utils function
|
I will merge and address the comments in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/HyperPlay-Gaming/product-management/issues/654