Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus logging #2171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quarkus logging #2171

wants to merge 1 commit into from
+444 −534

Conversation

barreiro
Copy link
Collaborator

@barreiro barreiro commented Nov 14, 2024 •
edited
Loading

Fixes Issue

Fixes #1993

Changes proposed

  • Move from org.jboss.logging.Logger to io.quarkus.logging.Log
  • Use debugf, infof and other "format" methods
  • String concatenation + when creating Exception mesages
  • Standardize on "".formatted() instead of String.format()

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@barreiro barreiro self-assigned this Nov 14, 2024
lampajr
lampajr reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barreiro, planning to look at this either today or tomorrow, meanwhile can you please apply the formatting as it looks like there are some uncommitted changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr left review comments

Assignees

@barreiro barreiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use simplified Quarkus logging instance
2 participants
@barreiro @lampajr