Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust ArrayNode nesting of jsonb agregate function. #666

Closed
wants to merge 1 commit into from
Closed

Adjust ArrayNode nesting of jsonb agregate function. #666

wants to merge 1 commit into from

Conversation

whitingjr
Copy link
Collaborator

@whitingjr whitingjr commented Sep 20, 2023 •
edited
Loading

… allowing Javascript to operate. The expected types are present for Array.reduce function to succeed.

Fixes Issue

fixes #639

Changes proposed

  • - Add testcase to reproduce the issue
  • - Added massaging of ArrayNode element contents to Number type (only when an integral value)

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new tests passed.

@whitingjr whitingjr marked this pull request as draft September 20, 2023 17:49
@jesperpedersen jesperpedersen added the type/enhancement An enhancement to an existing feature label Sep 20, 2023
@whitingjr whitingjr force-pushed the issue#639-fix-dataset-label-array-reduce branch from 093b89f to fe2a049 Compare September 21, 2023 14:17
@whitingjr whitingjr marked this pull request as ready for review September 21, 2023 14:35
@whitingjr whitingjr marked this pull request as draft September 21, 2023 14:36
@whitingjr
Add testcase to exercise reduce function. Add method to flatten the J…
4e9aa16 
…son object after db query allowing JS function to operate.
@whitingjr whitingjr force-pushed the issue#639-fix-dataset-label-array-reduce branch from fe2a049 to 4e9aa16 Compare September 21, 2023 14:45
@whitingjr whitingjr marked this pull request as ready for review September 21, 2023 14:45
@whitingjr whitingjr changed the title Convert ArrayNode elements from db query to expected Number data type. Adjust ArrayNode nesting of jsonb agregate function. Sep 21, 2023
@jesperpedersen
Copy link
Collaborator

Rebased, and merged.

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesperpedersen jesperpedersen Awaiting requested review from jesperpedersen

Assignees

@whitingjr whitingjr

Labels
type/enhancement An enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label extractor aggregation function not exposing value.
2 participants
@whitingjr @jesperpedersen