-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #701 #702 #703 #729 refactored out postgres callbacks and message bus usage #705
Conversation
Trying to add a new label to an existing schema is failing with the following exception:
|
I've added an amqp queue for label update/add/delete. |
@stalep I agree with the general direction of messaging, but I think we should use the constructs that the smallrye reactive messaging library provides i.e: http://smallrye.io/smallrye-reactive-messaging/4.7.0/concepts/blocking/ The current implementation using the smallrye context propagation managedExecutor is not handling failures and will take 1000 messages per channel an enqueue them in memory. If horreum crashes, we will lose those messages because as far as the amq broker is concerned, they have been delivered. We also have 3 native context switches per message received, if we use the smallrye reactive messaging @Blocking annotation, I think we will only have 2 |
Merged w/ some disabled test cases. Thanks for your contribution ! |
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)