Fix loading images messing up anchors on the supported robot page #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypfer
force-pushed
the
master
branch
2 times, most recently
from
04a911f to
5306e69
Compare
|
Sorry for leaving this PR in limbo for this long. I just tried the following with the result unfortunately being not ideal However, I also saw that WebStorm can do this so I think that would be the way to go. |
|
Ha I almost forgot this was here. No problem, thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
As discussed on Telegram I tried to fix the issue of anchors pointing to the wrong place on the supported robots page. I am relatively confident, that this fixes the issue, since in different browsers (Safari, Chrome, Firefox) and on throttled internet speeds it prevents the text from reflowing when the images are loaded. However reproducing the original bug of jumping to the wrong place proved to be difficult. I could somewhat consistently trigger it using an simulated iOS device after erasing all caches on it. I tried it several times with these changes and the issue did not occur, so I would say I am 90% certain that it works.
I did not want to globally overwrite the image styling, so I added a class to all images on the page. The width must be explicitly specified or it doesn't work, thus I set it to 100%. The aspect ratio of the images does not seem to be exactly 4 in all cases, but it seems like its close enough, otherwise it would need to be set for every image individually.