WIP: explain-mode for parts of arguments #3624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently-broken spike aims to extend #3555 (original issue: #3411) to report on sub-parts of arguments. Because this only makes sense for fixed-size collections - otherwise the minimal failing example would omit that part, so there'd be nothing to report on - we'll implement it for arguments to
st.builds()
, elements ofst.tuples()
, and for the non-optional keys inst.fixed_dictionaries()
.Not a top priority right now, so I'm opening this just to mark where it's up to and ensure that we don't lose any progress.
Because this means we might have many more reportable spans to report on, it might also require some performance optimizations. The two obvious big ones are:
ConjectureData
to natively support vary-this-span, which would save up to 50% of runtime when we retry on changed span sizegenerate_novel_prefix()
here, and exploit lexical ordering the same way?