fix flicky test

I-TECH-UW · Feb 12, 2025 · 9da6944 · 9da6944
1 parent be57b69
commit 9da6944
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/src/test/java/org/openelisglobal/address/PersonAddressServiceTest.java b/src/test/java/org/openelisglobal/address/PersonAddressServiceTest.java
@@ -9,7 +9,6 @@
 import org.openelisglobal.address.valueholder.AddressPK;
 import org.openelisglobal.address.valueholder.PersonAddress;
 import org.openelisglobal.person.service.PersonService;
-import org.openelisglobal.person.valueholder.Person;
 import org.springframework.beans.factory.annotation.Autowired;
 
 public class PersonAddressServiceTest extends BaseWebContextSensitiveTest {
@@ -28,14 +27,9 @@ public void init() throws Exception {
     @Test
     public void createPersonAddress_shouldCreatePersonAddress() throws Exception {
 
-        Person person = new Person();
-        person.setFirstName("john");
-        person.setLastName("Doe");
-        String personId = personService.insert(person);
-
         PersonAddress personAddress = new PersonAddress();
         personAddress.setAddressPartId("3");
-        personAddress.setPersonId(personId);
+        personAddress.setPersonId("3");
         personAddress.setType("D");
         personAddress.setValue("123");
 
@@ -71,14 +65,9 @@ public void deletePersonAddress_shouldDeletePersonAddress() throws Exception {
     @Test
     public void insert_shouldInsertPersonAdress() throws Exception {
 
-        Person person = new Person();
-        person.setFirstName("john");
-        person.setLastName("Doe");
-        String personId = personService.insert(person);
-
         PersonAddress personAddress = new PersonAddress();
         personAddress.setAddressPartId("5");
-        personAddress.setPersonId(personId);
+        personAddress.setPersonId("4");
         personAddress.setType("F");
         personAddress.setValue("123");
 

diff --git a/src/test/resources/testdata/personaddress.xml b/src/test/resources/testdata/personaddress.xml
@@ -30,6 +30,11 @@
 		country="USA" work_phone="10000002" home_phone="8000003"
 		cell_phone="0000001" primary_phone="10000002" fax="0002"
 		email="[email protected]" lastUpdated="2023-11-01 12:00:00" />
+	<person id="4" last_name="Kukkib" first_name="Faithb"
+		middle_name="Siannah" city="Dallas" state="Texas" zip_code="001"
+		country="USA" work_phone="10000002" home_phone="8000003"
+		cell_phone="0000001" primary_phone="10000002" fax="0002"
+		email="[email protected]" lastUpdated="2023-11-01 12:00:00" />
 
 	<person_address person_id="1" address_part_id="5"
 		type="P" value="12345678" />