Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated more reliable selectors in OrderEntityPage.js #OGC-35 #1470

Closed
wants to merge 0 commits into from

Conversation

Nirvanjha2004
Copy link

Pull Requests Requirements

  • [ yes] The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • [yes ] The PR includes a video showing the changes for the work done.
  • [yes ] The PR title follows conventional commit label standards.
  • [yes ] The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • [ yes] The changes include tests or are validated by existing tests.
  • [yes ] I have read and agree to the Contributing Guidelines of this project.

Summary

I have commented the old selectors and added more reliable selectors which will not break even if there is change in the ui

Screenshots

Screenshot 2025-01-29 235545

[Add relevant screenshots here if applicable]

Related Issue

https://uwdigi.atlassian.net/browse/OGC-35
[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@Nirvanjha2004
Copy link
Author

Hey @Bahati308 @mozzy11 can u review it once and let me know if any changes need to be addressed.. Thanks

Copy link
Contributor

@Bahati308 Bahati308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @Nirvanjha2004 , thanks for the work. Most of the features you have commented out are so crucial for the test to be successful and complete. Uncomment them and adjust a litle bit

@Nirvanjha2004
Copy link
Author

hello @Nirvanjha2004 , thanks for the work. Most of the features you have commented out are so crucial for the test to be successful and complete. Uncomment them and adjust a litle bit

Hello @Bahati308 i have updated it ... can u review it and let me if any other change is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants