Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to important End of Life components (Tomcat, Java, Spring) #1500

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a610193
upgrade to java 21 and tomcat 9
CalebSLane Jan 22, 2025
6c4daaf
migrate tomcat9 to 10, spring 5 to 6, javax to jakarta
CalebSLane Jan 24, 2025
0411441
migrate spring 6.0 -> 6.2
CalebSLane Jan 24, 2025
110f96f
updating and cleaning dependencies
CalebSLane Jan 28, 2025
8a750ea
Merge branch 'develop' into componentUpgrade
CalebSLane Jan 31, 2025
358b820
make develop changes compatible with tomcat
CalebSLane Jan 31, 2025
233a534
Merge branch 'Tomcat10' into componentUpgrade
CalebSLane Jan 31, 2025
46bb38d
use updated versions in non-dev environment too
CalebSLane Jan 31, 2025
8d3a390
Merge branch 'Tomcat10' of github.com:I-TECH-UW/OpenELIS-Global-2 int…
CalebSLane Jan 31, 2025
74c31ba
Merge branch 'componentUpgrade' of github.com:CalebSLane/OpenELIS-Glo…
CalebSLane Jan 31, 2025
b466ad1
fix security issues preventing jsps to not load
CalebSLane Feb 1, 2025
78ca4d0
clean up files for pull request, match formatting
CalebSLane Feb 3, 2025
0872fb2
Merge branch 'develop' into componentUpgrade
CalebSLane Feb 3, 2025
23332b3
remove duplicate instructions
CalebSLane Feb 3, 2025
4cfb22f
cleanup pom
CalebSLane Feb 3, 2025
264f631
apply spotless to java files
CalebSLane Feb 3, 2025
8fd6aaa
apply spotless formatting to pom.xml
CalebSLane Feb 3, 2025
f4db4b0
apply spotless to xml files
CalebSLane Feb 3, 2025
71b2131
change java version in github action
CalebSLane Feb 3, 2025
4dd9c0c
update maven compiler so parameter names can be inferred
CalebSLane Feb 4, 2025
f486772
reapply spotless formatting
CalebSLane Feb 4, 2025
16fa544
Merge branch 'develop' into componentUpgrade
CalebSLane Feb 5, 2025
eac4b4f
apply formatting after merge
CalebSLane Feb 5, 2025
56b0820
Merge branch 'develop' into componentUpgrade
CalebSLane Feb 12, 2025
f950c45
spotless apply
CalebSLane Feb 12, 2025
bccf208
Merge branch 'develop' into componentUpgrade
CalebSLane Feb 12, 2025
6d85b64
spotless apply
CalebSLane Feb 12, 2025
4b381bf
replace javax.servlet with jakarta.servlet
CalebSLane Feb 12, 2025
0600fbf
spotless
CalebSLane Feb 12, 2025
bc1069f
bump version to 3.2
CalebSLane Feb 13, 2025
cb2d669
Merge branch 'develop' into componentUpgrade
mozzy11 Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
checkFormat-build-unitTest-and-run:
runs-on: ubuntu-latest
steps:
- name: Set up JDK 11
- name: Set up JDK 21
uses: actions/setup-java@v1
with:
java-version: 11
java-version: 21
- name: Cache local Maven repository
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -51,4 +51,4 @@ jobs:
if: github.event_name == 'push'
uses: JamesIves/github-pages-deploy-action@v4
with:
folder: target/html/
folder: target/html/
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
##
# Build Stage
#
FROM maven:3-jdk-11 AS build
FROM maven:3-eclipse-temurin-21 AS build

RUN --mount=target=/var/lib/apt/lists,type=cache,sharing=locked \
--mount=target=/var/cache/apt,type=cache,sharing=locked \
Expand Down Expand Up @@ -49,7 +49,7 @@ RUN --mount=type=cache,target=/root/.m2,sharing=locked \
##
# Run Stage
#
FROM tomcat:8.5-jdk11
FROM tomcat:10-jre21

COPY install/createDefaultPassword.sh ./

Expand Down
34 changes: 19 additions & 15 deletions Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@
##
# Build Stage
#
FROM maven:3-jdk-11 as build
FROM maven:3-eclipse-temurin-21 AS build
ADD ./dataexport /build/dataexport
##
# Build DataExport

WORKDIR /build/dataexport/dataexport-core
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn dependency:go-offline
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn clean install -DskipTests
WORKDIR /build/dataexport/
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn dependency:go-offline
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn clean install -DskipTests



RUN --mount=target=/var/lib/apt/lists,type=cache,sharing=locked \
--mount=target=/var/cache/apt,type=cache,sharing=locked \
Expand All @@ -10,6 +26,7 @@ RUN --mount=target=/var/lib/apt/lists,type=cache,sharing=locked \
&& apt-get -y --no-install-recommends install \
git apache2-utils


##
# Copy Source Code
#
Expand All @@ -25,19 +42,6 @@ ARG DEFAULT_PW="adminADMIN!"
ADD ./install/createDefaultPassword.sh /build/install/createDefaultPassword.sh
RUN ./install/createDefaultPassword.sh -c -p ${DEFAULT_PW}

##
# Build DataExport
#
WORKDIR /build/dataexport/dataexport-core
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn dependency:go-offline
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn clean install -DskipTests
WORKDIR /build/dataexport/
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn dependency:go-offline
RUN --mount=type=cache,target=/root/.m2,sharing=locked \
mvn clean install -DskipTests

##
# Build the Project
Expand All @@ -53,7 +57,7 @@ RUN --mount=type=cache,target=/root/.m2,sharing=locked \
##
# Run Stage
#
FROM tomcat:8.5-jdk11
FROM tomcat:10-jre21

ADD install/createDefaultPassword.sh ./

Expand Down
6 changes: 4 additions & 2 deletions dev.docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ services:

oe.openelis.org:
container_name: openelisglobal-webapp
build:
context: .
dockerfile: Dockerfile.dev
image: itechuw/openelis-global-2-dev:develop
# platform: linux/amd64
depends_on:
Expand All @@ -50,7 +53,6 @@ services:
networks:
default:
ipv4_address: 172.20.1.121

environment:
- DEFAULT_PW=adminADMIN!
- TZ=Africa/Nairobi
Expand All @@ -60,7 +62,7 @@ services:
- key_trust-store-volume:/etc/openelis-global
- ./volume/plugins/:/var/lib/openelis-global/plugins
- ./volume/tomcat/oe_server.xml:/usr/local/tomcat/conf/server.xml
- ./target/OpenELIS-Global.war:/usr/local/tomcat/webapps/OpenELIS-Global.war
# - ./target/OpenELIS-Global.war:/usr/local/tomcat/webapps/OpenELIS-Global.war
- ./volume/properties/SystemConfiguration.properties:/var/lib/openelis-global/properties/SystemConfiguration.properties
- lucene_index-vol:/var/lib/lucene_index
secrets:
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/Login.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ function Login(props) {
password: "",
}}
onSubmit={(values) => {
doLogin(values);
fetch(config.serverBaseUrl + "/LoginPage", {
//includes the browser sessionId in the Header for Authentication on the backend server
credentials: "include",
Expand Down
10 changes: 6 additions & 4 deletions frontend/src/components/layout/Header.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,12 @@ function OEHeader(props) {
}, []);

useEffect(() => {
getFromOpenElisServer("/rest/menu", (res) => {
handleMenuItems("menu", res);
});
}, []);
userSessionDetails.authenticated
? getFromOpenElisServer("/rest/menu", (res) => {
handleMenuItems("menu", res);
})
: console.log("User not authenticated, not getting menu");
}, [userSessionDetails.authenticated]);

const panelSwitchLabel = () => {
return userSessionDetails.authenticated ? "User" : "Lang";
Expand Down
Loading
Loading