Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten Collected ARV patient and Associated Patient Report from jsp to new UI in react! #785

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

manishjha-04
Copy link
Contributor

@manishjha-04 manishjha-04 commented Mar 10, 2024

Rewritten Collected ARV patient and Associated Patient Report in new UI !

The issue #741 and this pull request is a continuation of pull request #780

Before:

Recording.2024-03-10.130037.mp4

After:

Recording.2024-03-10.140508.mp4

@manishjha-04
Copy link
Contributor Author

Hey @mozzy11 , 👋, in this pull request, I've implemented breadcrumbs that change based on params. Please review and let me know if it looks good so I can implement it accordingly in the rest of my pull requests.

Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

I think you can go ahead and add this to all your other prs

@github-actions github-actions bot added the merge conflict Merge Conflicts label Mar 18, 2024
Copy link

👋 Hi, @manishjha-04,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@mozzy11 mozzy11 merged commit a5645fc into I-TECH-UW:develop_3x Mar 18, 2024
3 of 4 checks passed
@manishjha-04 manishjha-04 deleted the reportById branch March 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants