Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMK_COSS log likelihood for reweighting #903

Open
wants to merge 88 commits into
base: devel
Choose a base branch
from
Open

Conversation

jamesmkrieger
Copy link
Contributor

@jamesmkrieger jamesmkrieger commented Mar 10, 2025

This adds a new protocol and viewer for calculating image-volume log likelihoods using either angular_continuous_assign2 or my new program in xmipp branch jmk_new_residuals (see I2PC/xmipp#991).

The protocol compares a set of N images against M volumes and outputs a duplicated set of images (NxM) with columns for residuals and log likelihoods. It also outputs a matrix as in npy file format, which is the input for the reweighting estimate protocol and the viewer.

This now works well for real images e.g.
Screenshot 2025-03-05 124338

Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, but Xmipp needs a test for all protocols, especially if it is a new one.
It also helps me to check the protocol and future changes



class XmippProtComputeLikelihood(ProtAnalysis3D):
"""This protocol computes the likelihood of a set of particles with assigned angles when compared to a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the line break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants