-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of dynamic dependencies #905
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that _binTagVersion
and _pluginTagVersion
are still around with the release name (Oceanus, Poseidon...). With the new semantic versioning, do they still make sense? Even if we give names to major releases, it is possible that plugin-bin names to get out of sync.
Starting from this new release, the naming also will change, in which way still has to be decided, but it's a minor issue, since it's only something "visual". There are several options:
In my opinion, we could remove them altogether, as it is the simpler and more trouble-free option, but that's something that requires certain degree of consensus to happen. |
The init.py has to change to launch the xmipp3_installer |
No, it doesn't, as xmipp already calls the installer. From outside xmipp, (that means, when using it either from command line or from the plugin), the installation is done exactly the same way as before. |
I agree. Another possibility would be to only give names to the xmipp (a secas) releases. |
I think this option is good, albeit with a previous discussion to define some minor details. It could get us more time to focus on what really matters. Wbw..M |
|
Note: This PR needs to be merged after xmipp-995.
xmipp3-installer
will now be automatically installed with the plugin to ease Xmipp's new installation process.v3.24.0
, for example), a new dynamic tagv3
is used, to avoid needing to release a new version of the plugin just because a new release of xmipp was generated. Now releases in the plugin will only be tiggered by changes in the code of the plugin itself, nothing else.