Identity Map V3 #83
Identity Map V3 #83
Conversation
src/test/java/com/uid2/client/IdentityMapV3IntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/uid2/client/IdentityMapV3IntegrationTests.java
Outdated
Show resolved
Hide resolved
|
|
||
| Response response = new Response(identityMapInput); | ||
|
|
||
| response.assertUnmapped("INVALID", "this is not a hashed email"); |
There was a problem hiding this comment.
curious, why have the errors changed to CAPS and a single word?
There was a problem hiding this comment.
That's the code we return from the APIs. I don't know why we've changed the codes from the previous version. Perhaps @gmsdelmundo has some context one he's back next week. I didn't realize it was not always like that.
I guess this makes it look more like an error code and less like an end-user message.
There was a problem hiding this comment.
So this means error handling is no longer a drop-in replacement? Especially concerned about optout - if we change this to caps we will break someone.
There was a problem hiding this comment.
Good point, but a discussion on the API side, not in SDK - here we just return whatever APIs return.
We'll consider changing this in API.
There was a problem hiding this comment.
@jon8787 after some discussion, we've decided to keep the APIs as is and change the SDKs to return an enum. Any unknown unmaped statuses will become "UNKNOWN".
This will still be a breaking change, but it will be obviously breaking instead of silently breaking with changing strings.
No description provided.