Interface cleanup and simplification · IABTechLab/uid2-ios-sdk@200a3bf

Triggered via pull request July 25, 2024 13:59

dcaunt

opened #45

dave/cleanup

Status Success

Total duration 7m 32s

Artifacts –

test-pull-request.yml

on: pull_request

8 warnings

Code Tests: Sources/UID2/UID2Client.swift#L123

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)

Code Tests: Sources/UID2/Networking/DataEnvelope.swift#L47

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)

Code Tests: Sources/UID2/Data/IdentityPackage.swift#L20

This memberwise initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)

Code Tests: Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/Networking/AppUID2Client.swift#L176

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)

Code Tests: Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/Networking/AppUID2Client.swift#L214

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)

Code Tests: Sources/UID2/UID2Manager.swift#L417

File should contain 400 lines or less: currently contains 417 (file_length)

Code Tests: Sources/UID2/UID2Manager.swift#L12

Type body should span 250 lines or less excluding comments and whitespace: currently spans 253 lines (type_body_length)

Code Tests: Development/UID2SDKDevelopmentApp/UID2SDKDevelopmentApp/RootView.swift#L83

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)