Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CocoaPods podspec #18

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add CocoaPods podspec #18

merged 2 commits into from
Apr 26, 2024

Conversation

dcaunt
Copy link
Collaborator

@dcaunt dcaunt commented Apr 22, 2024

  • Add podspec to the repo
  • Add lint job to GitHub workflow
  • Simplify SDK versioning

This does not publish to pod trunk.

@dcaunt dcaunt marked this pull request as ready for review April 25, 2024 10:08
IanDBird
IanDBird previously approved these changes Apr 25, 2024
IanDBird
IanDBird previously approved these changes Apr 25, 2024
Copy link

@IanDBird IanDBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcaunt
Copy link
Collaborator Author

dcaunt commented Apr 26, 2024

Noting that GitHub actions have started running on macos-14, which doesn't have swiftlint installed. I'm not quite sure what has caused the change, as we've always used runs-on: macos-latest but for now I've forced it to run on macos-12 to unblock.

@dcaunt dcaunt merged commit a8b3dbc into main Apr 26, 2024
1 check passed
@dcaunt dcaunt deleted the dave/cocoapods branch April 26, 2024 12:32
dcaunt added a commit that referenced this pull request Apr 28, 2024
dcaunt added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants