Reduce Crypto dependencies #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcaunt
force-pushed
the
dave/crypto-dependencies
branch
from
caf3d68 to
ab90e22
Compare
dcaunt
force-pushed
the
dave/crypto-dependencies
branch
from
ab90e22 to
6735942
Compare
IanDBird
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were depending on swift-certificates but only for the
SubjectPublicKeyInfodefinitions. By importing that file we can reduce the dependencies to justswift-asn1. This should unblock CocoaPods support, but would be a win anyway.SubjectPublicKeyInfoandAlgorithmIdentifier.swiftare imported verbatim, with a permalink comment.