Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test data folders #399

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

phackstock
Copy link
Contributor

@phackstock phackstock commented Sep 23, 2024

Closes #400.
This PR implements the much needed clean-up of the test data folder.
From previously:

├── data
│   ├── add-missing-variables
│   ├── check_aggregate
│   ├── custom_dimension_nc
│   ├── definitions1
│   ├── definitions2
│   ├── definitions3
│   ├── double_stacked_external_repo
│   ├── duplicate-code-list
│   ├── duplicate_code_raises
│   ├── duplicate_tag_raises
│   ├── empty_definitions_dir
│   ├── end_whitespace
│   ├── excel_io
│   ├── extras_nc
│   ├── failing_variable_codelist
│   ├── general-config
│   ├── general-config-only
│   ├── general-config-only-country
│   ├── general-config-only-nuts
│   ├── general_filtering
│   ├── hidden_character
│   ├── invalid_yaml
│   ├── meta
│   ├── model_registration
│   ├── multiple_unit_codelist
│   ├── nomenclature_configs
│   ├── non-default_dimensions
│   ├── non-default_dimensions_one_empty
│   ├── non-default_folders
│   ├── region_aggregation
│   ├── region_codelist
│   ├── region_processing
│   ├── regionprocessor_duplicate
│   ├── regionprocessor_exclude_region_overlap
│   ├── regionprocessor_not_defined
│   ├── regionprocessor_unexpected_region
│   ├── regionprocessor_working
│   ├── region_to_filter_codelist
│   ├── required_data
│   ├── simple_codelist
│   ├── stray_tag
│   ├── structure_validation
│   ├── structure_validation_fails
│   ├── structure_validation_no_mappings
│   ├── tagged_codelist
│   ├── validation
│   ├── validation_nc
│   ├── variable_codelist_complex_attr
│   └── workflow

we now have:

├── data
│   ├── check_aggregate
│   ├── cli
│   ├── codelist
│   ├── config
│   ├── data_structure_definition
│   ├── IO
│   ├── meta_validator
│   ├── model_registration
│   ├── region_processing
│   ├── required_data
│   ├── validation
│   └── workflow

This was referenced Sep 23, 2024
@phackstock phackstock added the refactor Refactoring or clean up label Sep 23, 2024
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

One minor quibble: maybe rename the folder “IO” to lowercase for consistency.

But good to be merged either way.

Copy link
Collaborator

@dc-almeida dc-almeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, quite convenient!

@phackstock phackstock merged commit 9314fef into IAMconsortium:main Sep 24, 2024
11 checks passed
@phackstock phackstock deleted the refactor/clean-up-test-data branch September 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up the test data folder
3 participants