Add a range-validation feature #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
phackstock
requested changes
Feb 19, 2025
| year: 2010 | ||
| validation: | ||
| - range: [ 1, 5 ] | ||
| - warning_level: low |
There was a problem hiding this comment.
I would remove everything except the range criterion since this is the one we want to test, not upper and lower bound.
There was a problem hiding this comment.
Done, and I renamed all test files to have a more intuitive structure.
|
|
||
|
|
||
| class DataValidationCriteria(IamcDataFilter): | ||
| validation: list[DataValidationBounds | DataValidationValue | DataValidationRange] |
There was a problem hiding this comment.
I'd refer to the shared base class of the different validation options.
Suggested change
| validation: list[DataValidationBounds | DataValidationValue | DataValidationRange] | |
| validation: list[DataValidationItem] |
There was a problem hiding this comment.
This doesn't seem to work...
phackstock
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #473 because @dc-almeida is on leave and I'd like to use this feature for scenario analysis. The PR implements the review comments by @phackstock made in #473.
Closes #471